Implement qir-qsim app for dynamic measurement handling #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
which was accidentally copied into the top level
sethrj
reviewed
Nov 22, 2024
src/qirqsim/BufferManager.hh
Outdated
|
|
||
| // Define a hash function for std::pair | ||
|
|
||
| struct pair_hash |
There was a problem hiding this comment.
These classes need to be in the qiree namespace, and the buffer manager in particular should be qiree::detail in a detail subdir
Remark: Compares only empty output for now until we find a way to properly store the result and not just print as we go. Temporarily using lowercase qsim. Will modify class names later with the others at the same time.
This commit will fail tests since I am documenting the file name change separately.
bell_ccx.ll to examples folder and dynamicbv.ll to test data folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation in this PR was authored by @vicenley , @sethrj , and @wongey with contributions from @danclaudino
and @ausbin. This provides a resolution to Issue #3.
Notes:
qsimlibraries. The first build of qiree with this implementation takes a little while...qir-xaccandqir-qsimhave been defaulted to OFF. They have to be turned ON during cmake for the executable to be generated.group-tuplesoption forqsimTuplesRuntimehas been temporarily deactivated. We can reactivate after we are happy with the implementation.--shotscan be triggered as usual.teleport.llfile was modified slightly to match the one in the paper.@sethrj : For this commit, I had performed a manual comparison with the files from the private repo to the most recent version of QIR-EE and the merge was smooth on my fork. However, I did NOT compare with @ausbin's recent PRs. Hopefully the conflicts will be at a minimum.